On Wed, 10 Apr 2024 08:41:19 GMT, Christian Stein <cst...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more tests for ambiguities.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
> line 3553:
>
>> 3551: # 0: symbol
>> 3552: compiler.err.import.module.does.not.read=\
>> 3553: current modules does not read: {0}
>
> Suggestion:
>
> current module does not read: {0}
>
>
> It would even be better to print the name of the "current" module, so that
> the user-facing message reads:
> `current module foo does not read module bar - possible fix: add "requires
> bar;" to foo's module descriptor `
Thanks. I've tweaked the error to include the module name here:
https://github.com/openjdk/jdk/pull/18614/commits/7cfaff80eac6261b62c5cdb9614a0e708bce7e33
Regarding possible fix(es) - it may be better to introduce some framework for
that, and convert the most typical errors, separately. (As I don't think we do
that for other errors.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18614#discussion_r1559616761
