On Mon, 1 Apr 2024 18:24:53 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Suchismith Roy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> spaces > > src/java.base/aix/classes/jdk/internal/loader/ClassLoaderHelper.java line 48: > >> 46: * file may be located at the alternate location. >> 47: * For most platforms, this behavior is not supported and returns >> null. >> 48: */ > > Suggestion: > > /** > * AIX implementation of JVM_LoadLibrary handles the alternate path name > mapping. > * If loading of the given library name with ".so" suffix fails, it will > attempt to load the library of > * the same name with ".a" suffix as the alternate name. > * > * This method simply returns null. It could implement the alternate name > converting ".so" with ".a" suffix but redundant. Nit: please add a new line above line 43. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1546683634
