On Tue, 26 Mar 2024 21:56:48 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> implement suggestions > > test/jdk/java/text/Format/MessageFormat/CompactSubFormats.java line 29: > >> 27: * @summary Test MessageFormatPattern ability to recognize and produce >> 28: * appropriate FormatType and FormatStyle for >> CompactNumberFormat. >> 29: * @run junit/othervm -Duser.language=en -Duser.country=US >> CompactSubFormats > > I would instantiate MessageFormat explicitly with the `US` locale (using the > 2-arg constructor), instead of implicitly specifying it with the system > property. Thanks for the review and suggestions, PR should be updated. (I presume you meant the 2-arg Locale.of() method, not the constructor) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18498#discussion_r1540182774
