On Mon, 25 Mar 2024 20:34:06 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> The header file contains more claims >> https://github.com/veorq/SipHash/blob/master/halfsiphash.h > > That header only contains a single function declaration for an entry point > into the implementation. > HotSpot doesn't use that function, and doesn't have anything with a > corresponding signature. So it's > not in any way derived from that header. The HotSpot code is derived from > the .c file only, so that's > the license we should be referencing. The problem is that the project is a joined work and has multiple variants of copyrights (see the readme). I don’t think it’s on the safe side to pick a single (non recent) copyright - especially if you change attribution after the fact. But that’s just me ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1538209271
