On Sat, 16 Mar 2024 22:34:25 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Update the code gen code in CallGeneratorHelper to reflect the latest state >> of the libTest(Downcall/Upcall)(Stack).c and shared.h files. >> >> - The previous code wanted users to pipe stdout into a file. But, since we >> have 5 files that need to be created, and the names of those files is >> important too, I've changed the script to write to those files directly >> instead. >> - I moved the definition of `S_FFFF` to libVarArgs.c where it's used, as >> it's not actually generated by CallGeneratorHelper. >> - GitHub doesn't render the changes to some of the files, but those files >> only contain either white space changes (some missing spaces after `,`), and >> copyright header updates. > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision: > > Delete extra space > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> Nice cleanup. No changes in libTestDowncallStack.c (not even minor ones) ? ------------- Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18269#pullrequestreview-1949642772
