On Wed, 13 Mar 2024 14:23:01 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Generate large strings in parameter generator methods > > I was thinking more something like > > var tenMillionBlanks = tenMillionBlanks(); > > and similarly for `tenMillionsZeros`, thus maintaining the `private static` > (but not `final` ;-) ) methods as in your previous commit. > But if you are happy with the last commit, it's OK as well. > > Can you please add the bug id to `@bug` and correct the typo, as suggested > [here](https://github.com/openjdk/jdk/pull/18264#issuecomment-1994382507)? > > Otherwise looks fine. Thanks, @rgiulietti for reviewing this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18264#issuecomment-1999033956
