On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't >> need the packaged modules being present. A.k.a run-time image based jlink. >> Fundamentally this patch adds an option to use `jlink` even though your JDK >> install might not come with the packaged modules (directory `jmods`). This >> is particularly useful to further reduce the size of a jlinked runtime. >> After the removal of the concept of a JRE, a common distribution mechanism >> is still the full JDK with all modules and packaged modules. However, >> packaged modules can incur an additional size tax. For example in a >> container scenario it could be useful to have a base JDK container including >> all modules, but without also delivering the packaged modules. This comes at >> a size advantage of `~25%`. Such a base JDK container could then be used to >> `jlink` application specific runtimes, further reducing the size of the >> application runtime image (App + JDK runtime; as a single image *or* >> separate bundles, depending on the app being modularized). >> >> The basic design of this approach is to add a jlink plugin for tracking >> non-class and non-resource files of a JDK install. I.e. files which aren't >> present in the jimage (`lib/modules`). This enables producing a `JRTArchive` >> class which has all the info of what constitutes the final jlinked runtime. >> >> Basic usage example: >> >> $ diff -u <(./bin/java --list-modules --limit-modules java.se) >> <(../linux-x86_64-server-release/images/jdk/bin/java --list-modules >> --limit-modules java.se) >> $ diff -u <(./bin/java --list-modules --limit-modules jdk.jlink) >> <(../linux-x86_64-server-release/images/jdk/bin/java --list-modules >> --limit-modules jdk.jlink) >> $ ls ../linux-x86_64-server-release/images/jdk/jmods >> java.base.jmod java.net.http.jmod java.sql.rowset.jmod >> jdk.crypto.ec.jmod jdk.internal.opt.jmod >> jdk.jdi.jmod jdk.management.agent.jmod jdk.security.auth.jmod >> java.compiler.jmod java.prefs.jmod java.transaction.xa.jmod >> jdk.dynalink.jmod jdk.internal.vm.ci.jmod >> jdk.jdwp.agent.jmod jdk.management.jfr.jmod jdk.security.jgss.jmod >> java.datatransfer.jmod java.rmi.jmod java.xml.crypto.jmod >> jdk.editpad.jmod jdk.internal.vm.compiler.jmod >> jdk.jfr.jmod jdk.management.jmod jdk.unsupported.desktop.jmod >> java.desktop.jmod java.scripting.jmod java.xml.jmod >> jdk.hotspot.agent.jmod jdk.i... > > Severin Gehwolf has updated the pull request incrementally with one > additional commit since the last revision: > > Fix comment in autoconf file make/Images.gmk line 125: > 123: > 124: RL_BUILD_MODULE_NAME := jdk.unsupported_jlink_runtime > 125: RL_CREATE_PLUGIN_MOD_OUTPUT := > $(SUPPORT_OUTPUTDIR)/$(RL_BUILD_MODULE_NAME) This would go better in `$(BUILDTOOLS_OUTPUTDIR)`. make/Images.gmk line 126: > 124: RL_BUILD_MODULE_NAME := jdk.unsupported_jlink_runtime > 125: RL_CREATE_PLUGIN_MOD_OUTPUT := > $(SUPPORT_OUTPUTDIR)/$(RL_BUILD_MODULE_NAME) > 126: JDK_RUN_TIME_IMAGE_SUPPORT_DIR := > $(SUPPORT_OUTPUTDIR)/images/runtime-link-support Suggestion: JDK_RUNTIME_IMAGE_SUPPORT_DIR := $(SUPPORT_OUTPUTDIR)/images/runtime-link-support or just inline it as it's only used in one location. make/Images.gmk line 132: > 130: JLINK_RUNTIME_CREATE_ARG += > -J--add-exports=java.base/jdk.internal.jimage=$(RL_BUILD_MODULE_NAME) > 131: JLINK_RUNTIME_CREATE_ARG += > -J--add-exports=jdk.jlink/jdk.tools.jlink.internal=$(RL_BUILD_MODULE_NAME) > 132: JLINK_RUNTIME_CREATE_ARG += --create-linkable-runtime > jimage=$(JDK_LINK_OUTPUT_DIR)/lib/modules:module-path=$(IMAGES_OUTPUTDIR)/jmods I would suggest using recommendation 17 from the [style guideline](https://openjdk.org/groups/build/doc/code-conventions.html) here. Suggestion: JLINK_RUNTIME_CREATE_ARG := \ -J--module-path=$(RL_CREATE_PLUGIN_MOD_OUTPUT) \ -J--add-exports=java.base/jdk.internal.module=$(RL_BUILD_MODULE_NAME) \ -J--add-exports=java.base/jdk.internal.jimage=$(RL_BUILD_MODULE_NAME) \ -J--add-exports=jdk.jlink/jdk.tools.jlink.internal=$(RL_BUILD_MODULE_NAME) \ --create-linkable-runtime jimage=$(JDK_LINK_OUTPUT_DIR)/lib/modules:module-path=$(IMAGES_OUTPUTDIR)/jmods \ # or just inline as it's only used in one location. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1525282378 PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1525283190 PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1525277218
