> Can I please get a review of this test-only change which proposes to address > https://bugs.openjdk.org/browse/JDK-8328066? > > The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue, > the failure was observed on linux-86 instance on a GitHub jobs run. > > The commit in this PR proposes to add relevant `@requires` so that the test > is only run on 64 bit VM and expects the `os.maxMemory` to be > 2G. > > The change has been tested on a linux-x86 run in GitHub actions job, plus > even on local and CI 64 bit VM environments. No failures have been noticed.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: Mark's suggestion - no need for os.maxMemory ------------- Changes: - all: https://git.openjdk.org/jdk/pull/18290/files - new: https://git.openjdk.org/jdk/pull/18290/files/e819081e..ff708ecf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18290&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18290&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18290.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18290/head:pull/18290 PR: https://git.openjdk.org/jdk/pull/18290
