On Wed, 13 Mar 2024 18:01:21 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> The intermittent failure of ObjectStreamClassCaching is due to an incorrect > assumption about GC behavior and a race condition. > > Removed test based on incorrect assumptions about simultaneous clearing of > WeakReferences. > Added a run of the test using ZGC, (previously omitted) Marked as reviewed by iris (Reviewer). test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java line 53: > 51: /* > 52: * Disabled for ZGC Generational. > 53: * TODO: Find correct appropriate solution to the flakiness of this test. Shouldn't you also remove the comment at line 52 since this test is no longer disabled? ------------- PR Review: https://git.openjdk.org/jdk/pull/18284#pullrequestreview-1934946970 PR Review Comment: https://git.openjdk.org/jdk/pull/18284#discussion_r1523749769
