On Tue, 12 Mar 2024 18:13:28 GMT, Joe Wang <jo...@openjdk.org> wrote:

> Irrelevant to this doc change, I happen to notice some of the 
> jdk`<version>`-suported-locales docs might have not been updated. For 
> example, 
> https://www.oracle.com/java/technologies/javase/jdk20-suported-locales.html 
> had "CLDR release 39" rather than 42 as stated here. Similarly 
> jdk19-suported-locales.html -> 39 instead of 41, 18 was correctly -> 39, but 
> 17 -> 35.1, and so on.

Thanks for pointing it out. Will let the doc people know. It is at least good 
that the latest doc for JDK21 is correct.

> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 148:
> 
>> 146:  * "SPI" in order for the Java runtime to load them from the classpath.
>> 147:  *
>> 148:  * @implNote The JDK uses locale data from the Unicode Common Locale 
>> Data Repository
> 
> The full name may be moved to where the acronym was first used, e.g. "CLDR": 
> the Unicode Common Locale Data Repository (CLDR) is a provider based on 
> Unicode Consortium's <a href="http://cldr.unicode.org/";>CLDR Project</a>. If 
> you decide to do that, then we may use it here to state: The JDK uses CLDR to 
> implement locale-sensitive APIs in the java.util and java.text packages.

Used the full name in both places, as they are the locations that refer to the 
Unicode's locale data. Other "CLDR" represents the JDK's CLDR locale data 
provider.

> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 154:
> 
>> 152:  * version of CLDR used in each JDK release.
>> 153:  * <table class="striped">
>> 154:  * <caption style="display:none">Shows JDK releases and supported CLDR 
>> versions</caption>
> 
> nit: the word "Shows" can be omitted.

Good point. Removed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18243#issuecomment-1992325490
PR Review Comment: https://git.openjdk.org/jdk/pull/18243#discussion_r1521969545
PR Review Comment: https://git.openjdk.org/jdk/pull/18243#discussion_r1521969490

Reply via email to