On Sun, 10 Mar 2024 13:47:06 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Please review this PR which removes the 19 deprecated `xxObject*` alias >> methods from `jdk.internal.misc.Unsafe`. >> >> These methods were added in JDK-8213043 (JDK 12), presumably to allow >> `jsr166.jar` to be used across JDK versions. This was a follow-up fix after >> JDK-8207146 had renamed these methods to `xxReference*'. >> >> Since OpenJDK is now the single source of truth for `java.util.concurrent`, >> time has come to remove these deprecated alias methods. >> >> This change was initially discussed here: >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-March/119993.html >> >> Testing: This is a pure deletion of deprecated methods, so the PR includes >> no test changes and the `noreg-cleanup` label is added in the JBS. I have >> verified that all `test/jdk/java/util/concurrent/*` tests pass. >> >> Tagging @DougLea and @Martin-Buchholz to verify that this removal is timely. > > Eirik Bjørsnøs has updated the pull request incrementally with two additional > commits since the last revision: > > - Replace calls to Unsafe.putObject with Unsafe.putReference > - Update a code comment referencing Unsafe.compareAndSetObject to reference > Unsafe.compareAndSetReference instead Hello Eirik, Mandy, tier1, tier2, tier3 testing of the latest approved state of this PR passed without failures. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18176#issuecomment-1990867492
