On Tue, 5 Mar 2024 10:39:31 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> The change in jspawnhelper looks good. > > I think it would be simpler to have a separate > `jdk/java/lang/ProcessBuilder/JspawnhelperMisuse.java` test that simply > invokes the `jspawnhelper` and verifies the proper message is printed. It > would be more straightforward than trying to fit the _protocol_ test? Plus, > we can test 0, 1, 3, 4 args, not only 0 args in that test, and we can also > test 2 args with bad format. Yes, this makes the test cleaner[1]. Also it seems that there is another issue with process streams handling: the test started to pass only after I've flushed stdout in jspawnhelper [2]. [1] https://github.com/vpa1977/jdk/commit/ac7b5c13eaaa177058c3940cf5c817f4c729ef56 [2] https://github.com/vpa1977/jdk/commit/5f398d5344f4f525cee0e92029528a70fd8e2479 ------------- PR Comment: https://git.openjdk.org/jdk/pull/18112#issuecomment-1979592133
