On Wed, 28 Feb 2024 09:19:20 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Please review this PR which proposes that we officially deprecate the >> following four methods in the `java.util.zip` package: >> >> * `Inflater.getTotalIn()` >> * `Inflater.getTotalOut()` >> * `Deflater.getTotalIn()` >> * `Deflater.getTotalOut()` >> >> Since these legacy methods return `int`, they cannot safely return the >> number of bytes processed without the risk of losing information about the >> magnitude or even sign of the returned value. >> >> The corresponding methods `getBytesRead()` and `getBytesWritten()` methods >> introduced in Java 5 return `long`, and should be used instead when >> obtaining this information. >> >> Unrelated to the deprecation itself, the documentation currently does not >> specify what these methods are expected to return when the number of >> processed bytes is greater than `Integer.MAX_VALUE`. This PR aims to clarify >> this in the API specification. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Update method description and deprecation note for the three remaining > methods Looks good Eirik, thank you for your efforts on the doc updates ------------- Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17919#pullrequestreview-1906144415
