On Fri, 22 Sep 2023 15:33:11 GMT, Raffaello Giulietti <rgiulie...@openjdk.org>
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains six additional commits
>> since the last revision:
>>
>> - Start adding worst-case inputs for other math libraries.
>> - Merge branch 'master' into JDK-8316708
>> - Merge branch 'master' into JDK-8316708
>> - Fix typo found in code review.
>> - Add stated error bounds.
>> - JDK-8316708: Augment WorstCaseTests with more cases
>
> test/jdk/java/lang/Math/WorstCaseTests.java line 293:
>
>> 291:
>> 292: // Worst-case observed error
>> 293: {-0x1.0068b067c6feep-1, +0x1.0c335e2f0727p1},
>
> Similar considerations as for asin above.
> The "expected" value should be `0x1.0c335e2f0726fp1`.
For the new worst-case conditions I've pushed, if there is a "// check"
comment, the Math and StrictMath return values were the same and I did not yet
check which exact floating-point value should be used as the reference point.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15879#discussion_r1501123440
