On Tue, 20 Feb 2024 20:46:47 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> This provides a slightly more accurate bounding limit for >> `computeNextExponentialSoftCapped` when the computed bound is greater than >> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the >> `while (computeNextExponentialSoftCapped(rng, limit) < limit)` check in >> `computeNextGaussian` on line 1402 to always be true, making the >> `nextGaussian` runtime unbounded in the worst case. > > Is it practical to write a regression test for this situation? @jddarcy Added a regression test. Once some of my GitHub Actions runners are free to run it, https://github.com/Pr0methean/jdk/actions/runs/7983430797 will confirm that the test fails without the fix. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17703#issuecomment-1955797533
