On Wed, 14 Feb 2024 14:31:03 GMT, Scott Gibbons <sgibb...@openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove gcc lib fn; reduce spacial cases to 10 from 32 > > Thank you all for the reviews. I have been asked to simplify this code to > facilitate easier review, and to remove the gcc library code I used for > memcmp. We also discovered that special-casing up to 31 bytes of needle was > not necessary to get the performance gain. I will be commenting the code and > fixing the single build failure soon. Hi @asgibbons , I am getting following error with slowdebug build on Meteor Lake system. ERROR: Build failed for target 'images' in configuration 'linux-x86_64-server-slowdebug' (exit code 2) === Output from failing command(s) repeated here === * For target buildtools_create_symbols_javac__the.COMPILE_CREATE_SYMBOLS_batch: # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/jatinbha/sandboxes/jdk-reviews/jdk/src/hotspot/share/asm/assembler.hpp:169), pid=237140, tid=237235 # assert(is_bound() || is_unused()) failed: Label was never bound to a location, but it was used as a jmp target # # JRE version: OpenJDK Runtime Environment (23.0) (slowdebug build 23-internal-adhoc.sdp.jdk) # Java VM: OpenJDK 64-Bit Server VM (slowdebug 23-internal-adhoc.sdp.jdk, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64) # Problematic frame: # V [libjvm.so+0x4c9e3e] Label::~Label()+0x5c # # Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -- %E" (or dumping to /home/jatinbha/sandboxes/jdk-reviews/jdk/make/core.237140) # # An error report file with more information is saved as: # /home/jatinbha/sandboxes/jdk-reviews/jdk/make/hs_err_pid237140.log ... (rest of output omitted) ------------- PR Comment: https://git.openjdk.org/jdk/pull/16753#issuecomment-1953840322
