On Sun, 18 Feb 2024 10:56:03 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:

>> Please review this test-only cleanup PR in preparation for deprecating 
>> `Deflater.getTotalOut()` in JDK-8326096.
>> 
>> This PR replaces various calls 
>> in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to 
>> `Deflater.getTotalOut()` with calls to `Deflater.getBytesWritten()` when 
>> formatting some debugging output lines. 
>> 
>> Additionally, various debug output lines claim to print the result of 
>> calling `Deflater.getAdler`, but instead prints the output of 
>> `Deflater.getTotalOut'. This PR fixes this to print the actual Adler value 
>> instead.
>> 
>> Testing and verification: This is a test-only fix affecting only debug 
>> output. I have added the `noreg-self` label to the issue.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use more specific format specifier %d instead of %s

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17901#pullrequestreview-1887769471

Reply via email to