On Tue, 13 Feb 2024 17:54:43 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Dan Lutker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary var.
>
> test/lib/jdk/test/lib/Platform.java line 145:
>
>> 143: }
>> 144:
>> 145: public static boolean isOSX() {
>
> This seems like a real hack. Is there really no better way to identity how
> sleep is implemented.
> I'd probably favor an alternative that accepts multiple values for the
> expected value.
Just ignore the binary name and only check for argv1 is imho enough.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17798#discussion_r1488357647
