On Thu, 8 Feb 2024 21:16:45 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move the if-else nFmt checking to a package-private method in NumberFormat
>
> src/java.base/share/classes/java/text/MessageFormat.java line 780:
>
>> 778: }
>> 779: }
>> 780: else if (fmt != null) {
>
> This `else if` does not seem necessary
Originally this was needed to make patterns for ClassicFormat (since we could
not instanceof check it due to visibility), but as
ClassicFormat/DateTimeFormatter cannot be equality checked, this isn't needed.
Removed, thanks for spotting.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17663#discussion_r1483609034
