On Fri, 2 Feb 2024 22:24:49 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> We discussed this separately, but will go over again here in case others are >> interested. Since DTF does not implement `equals()`, even if we implement >> `equals()` for the `ClassicFormat`, we would basically still need to >> implement our own `equals()` for a DTF to effectively compare the >> ClassicFormats. >> >> I had also mentioned that we could reference check the pre-defined DTFs, but >> this won't work either actually. This is because we cannot reference check >> the DTFs, but rather the Format adapted DTFs, which mean they are now new >> ClassicFormats every time since we don't store them. > > Thanks. I think it is fine. The comment "does not implement equals and thus cannot be represented as a pattern" doesn't explain why it can be represented as a pattern. Can that be explained better? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17663#discussion_r1480011093
