On Wed, 24 Jan 2024 10:33:05 GMT, Quan Anh Mai <qa...@openjdk.org> wrote:
>> Hi,
>>
>> This patch introduces `JitCompiler::isConstantExpression` which can be used
>> to statically determine whether an expression has been constant-folded by
>> the Jit compiler, leading to more constant-folding opportunities. For
>> example, it can be used in `MemorySessionImpl::checkValidStateRaw` to
>> eliminate the lifetime check on global sessions without imposing additional
>> branches on other non-global sessions. This is similar to
>> `__builtin_constant_p` in GCC and clang.
>>
>> Please kindly give your opinion as well as your reviews, thanks very much.
>
> Quan Anh Mai has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address reviews
Naive question: the right way to use this would be almost invariably be like
this:
if (isCompileConstant(foo) && fooHasCertainStaticProperties(foo)) {
// fast-path
}
// slow path
Right? Then the expectation is that during interpreter and C1,
`isCompileConstant` always returns false, so we just never take the fast path
(but we probably still pay for the branch, right?). And, when we get to C2 and
this method is inlined, at this point we know that either `foo` is constant or
not. If it is constant we can check other conditions on foo (which presumably
is cheap because `foo` is constant) and maybe take the fast-path. In both
cases, there's no branch in the generated code because we know "statically"
when inlining if `foo` has the right shape or not. Correct?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17527#issuecomment-1908724632
