On Wed, 24 Jan 2024 18:12:35 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove redundant test from checkUnconditionallyExact > > test/micro/org/openjdk/bench/jdk/preview/patterns/Exactness.java line 1: > >> 1: /* > > The exactness predicates should have regression tests on their correct > operation in addition to any performance testing. I have this regarding numeric values [test/langtools/tools/javac/patterns/PrimitiveInstanceOfNumericValueTests.java](https://github.com/openjdk/jdk/pull/15638/files#diff-0c7b37309d920b4c1af93789aed337c9eb259ad31977b9ef395e7b8c4b47a6d6) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1465363618