On Wed, 24 Jan 2024 06:07:55 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   use null to denote boot class loader as delegation parent
>
> test/hotspot/jtreg/compiler/jvmci/LoadAlternativeJVMCI.java line 54:
> 
>> 52: 
>> 53:         ClassLoader pcl = ClassLoader.getPlatformClassLoader();
>> 54:         URLClassLoader ucl = new URLClassLoader(cp, null);
> 
> I am missing something here, a `URLClassLoader` first delegates to its parent 
> before searching its URLs, so how does this not find the platform loader 
> versions of the JVMCI classes?

With `new URLClassLoader(cp, null)`, the URL loader delegates directly to the 
boot loader, by-passing the platform loader.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17520#discussion_r1464529290

Reply via email to