On Tue, 23 Jan 2024 22:13:14 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add @implNote to Javadoc for toPattern(). > > src/java.base/share/classes/java/text/MessageFormat.java line 556: > >> 554: * does not necessarily equal the previously applied pattern. >> 555: * >> 556: * @implNote The string returned by this method can be used to >> create > > Hmm, I'm not sure about the current note, because its not true in all cases > (for example, some unknown subclass of Format). Maybe @naotoj has thoughts? Yes, my comment to the CSR was to explain the default implementation as the `@implNote`. Making it explicit would be helpful to readers. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17416#discussion_r1464096885
