On Tue, 23 Jan 2024 08:17:13 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolution > > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 5301: > >> 5299: vmovmskps(rtmp, mask, vec_enc); >> 5300: } >> 5301: shlq(rtmp, 5); // for 32 byte permute row of 8 x 32 bits. > > Suggestion: > > shlq(rtmp, 5); // for 32 byte permute row of 8 x 32 bits / 4 x 64 bits. > > Since you now merged the code of the two paths As per the latest patch, we are doing a double word permute, hence semantically its ok and in accordance with instruction sequence :-) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17261#discussion_r1463160336
