On Fri, 12 Jan 2024 11:22:13 GMT, Chris Hegarty <che...@openjdk.org> wrote:
>>> A process-related comment: this PR is against mainline, but the issue's Fix >>> Version/s is 22. This will create a bit of a mess if integrated. >> >> Thanks for the reminder Pavel. If accepted, then the change will be >> applicable to 23, 22, and 21. 0.2. I'll fix up and retarget the appropriate >> branches, repos, once we agree a way forward. > >> this PR is against mainline, but the issue's Fix Version/s is 22. > > I updated the fix version in JIRA, and followed the process as outlined in > https://mail.openjdk.org/pipermail/jdk-dev/2023-December/008560.html > @ChrisHegarty My 2¢—this change could impact existing classes which have > extended LTQ and knowingly, or unknowingly, presume that add and put delegate > to offer, which would (silently) break those classes when running on a newer > JDK (presuming this change gets merged). > > I think the change is in principle correct, with that said, I want to make > sure that the change is worth the potential compatibility risk (if any). Hi @viktorklang-ora , I agree with your comment regarding the potential impact, and the assumption of the implementation, however, you got it the wrong way round! ;-) The change I am proposing restores previous behaviour to pre-JDK 22. It is JDK 22 that has changed this. This is exactly why I am proposing the change ------------- PR Comment: https://git.openjdk.org/jdk/pull/17393#issuecomment-1889016400
