On Tue, 2 Jan 2024 07:43:03 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add @bug tag for 8322802
>
> test/jdk/java/util/zip/ZipCoding.java line 86:
>
>> 84: // ZipOutputStream sets the 'Language encoding flag'
>> when writing using UTF-8
>> 85: // UTF-8 should be used for decoding, even when opening
>> with a different charset
>> 86: Arguments.of("utf-8", "iso-8859-1",
>
> Hello Eirik, there are 3 streams of arguments above which use "utf-8" for
> writing out the entry. All those other 3 streams of arguments, use "utf-8"
> for reading too (which is OK). For each of those 3 streams of arguments,
> could you also add another argument stream which uses non-utf8 charset for
> reading, like you do here? I think that would give this a bit more coverage,
> especially for cases like the surrogates in comments and entry names.
Thanks, these cases got lost during my parameterization. I've added them back
now.
One such case would probably suffice to verify that the bit flag was
interpreted correctly, but it doesn't hurt to have some more variation here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17207#discussion_r1439274478
