On Wed, 13 Dec 2023 18:16:56 GMT, Weibing Xiao <d...@openjdk.org> wrote:

> Better Error Handling for Jar Tool Processing of "@File" <br>
> 
> This is a new PR for this PR since the original developer left the team. See 
> all of the review history at https://github.com/openjdk/jdk/pull/16423.
> 
> Thank you.

The implementation change looks okay, I think we mostly agreed that in the 
previous PR.

I don't have cycles to look at the test right now so I hope you can get another 
reviewer for the test update.

The other part to this is the man page. I chatted briefly with Ryan about this 
a few weeks ago as something that needs to updated (not this PR of course).

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17088#pullrequestreview-1785407802

Reply via email to