On Thu, 30 Nov 2023 20:59:01 GMT, Jorn Vernee <jver...@openjdk.org> wrote:

> Need to use `jlong_to_ptr` instead of raw cast.
> 
> I've also fixed another latent issue in `CLayouts` where we were initializing 
> `C_LONG_LONG` with the `long` layout. This was resulting in a class cast 
> exception when running the XorTest benchmark. The size of `long` on Linux x86 
> 32-bits is 4 bytes, so the returned layout has type `ValueLayout.OfInt` which 
> we then try to cast to `ValueLayout.OfLong`, resulting in a CCE. This would 
> also be an issue on Windows.
> 
> Testing: running XorTest benchmark on linux-x86 and windows-x64.

This pull request has now been integrated.

Changeset: 3b30095a
Author:    Jorn Vernee <jver...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/3b30095a63bdf8224a5625507a69942210a203a0
Stats:     5 lines in 2 files changed: 2 ins; 0 del; 3 mod

8321130: Microbenchmarks do not build any more after 8254693 on 32 bit platforms

Reviewed-by: mcimadamore, tschatzl

-------------

PR: https://git.openjdk.org/jdk/pull/16913

Reply via email to