On Mon, 6 Nov 2023 16:57:24 GMT, ExE Boss <d...@openjdk.org> wrote:
> These should probably use `{@snippet ...}`:
Good idea—I might do so when I have the opportunity.
> src/java.base/share/classes/java/util/stream/Gatherer.java line 549:
>
>> 547: return greedy;
>> 548: }
>> 549:
>
> Since [GH‑16213] was closed in favour of adding diamond inference to casts
> (e.g.: `(Integrator<>) Foo::bar` or `(Integrator.Greedy<>) Foo::bar`), these
> should probably be removed as well:
> Suggestion:
>
>
>
> [GH‑16213]: https://github.com/openjdk/jdk/pull/16213
@ExE-Boss Since there is no diamond casts yet, and this is a Preview, I think
it is safe enough to keep things as is and re-assess if/when such capabilities
are supported.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16420#issuecomment-1798238236
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1380639052
