On Mon, 30 Oct 2023 13:57:05 GMT, Raffaello Giulietti <rgiulie...@openjdk.org>
wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313621: assertTrue -> assertEquals
>
> test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal.java line 65:
>
>> 63: /**
>> 64: * @test
>> 65: * @bug 7032154
>
> Suggestion:
>
> * @bug 7032154 8313621
Not adding issue ID as this is a `noreg-self` issue.
> test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal.java line 78:
>
>> 76: */
>> 77: public class TestFloatingDecimal {
>> 78: private static final int NUM_RANDOM_TESTS = 100000;
>
> Suggestion:
>
> private static final int NUM_RANDOM_TESTS = 100_000;
So changed in b6e22fca1f9c992c2d92d89a63898d71495d5a4c.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16130#discussion_r1376610276
PR Review Comment: https://git.openjdk.org/jdk/pull/16130#discussion_r1376608725
