On Mon, 23 Oct 2023 22:19:15 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> implement feedback > > test/jdk/java/text/Format/ChoiceFormat/PatternsTest.java line 59: > >> 57: assertDoesNotThrow( ()-> new ChoiceFormat(pattern), >> 58: "Valid pattern should not have thrown an exception"); >> 59: } > > For those valid cases, it may be helpful to actually format some edge cases, > and check the results, especially for those odd ones. Or compare the parsed > arrays. Good point, added some code to actually compare the formatted values to the expected results as suggested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16324#discussion_r1369362862
