On Thu, 19 Oct 2023 15:21:02 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Here is the patch for risc-v: >> [riscv_panama_heap_segments.patch](https://github.com/openjdk/jdk/files/13043332/riscv_panama_heap_segments.patch) >> >> All `jdk_foreign` tests passed on linux-riscv with `-XX+VerifyOops >> -XX:+VerifyStack` and fastdebug build. > > @feilongjiang Thanks, I've added it to the PR > > @TheRealMDoerr Note that `reg_offset` is filtered out, and not handled by > `arg_shuffle`. So, it becomes the question whether shuffling a register, or > adding an offset to an oop takes more bytes. I think most of the > `native_invoker_size_per_arg` have some lenience built in though? (I did do > that for x64 and aarch64 at least). So, I think it will be okay. > > I've added an additional test case to the existing test for this, which > should stress the new code gen. > (https://github.com/openjdk/jdk/pull/16201/commits/dd9e9741de3ca07e6a4cc561002255f98e1e3330) @JornVernee please add this patch which addresses @RealLucy comments. [0001-Address-Lutz-Schmidt-s-review-comments.txt](https://github.com/openjdk/jdk/files/13046011/0001-Address-Lutz-Schmidt-s-review-comments.txt) Also tested additional test case on s390x that @JornVernee have added and I see it is passing. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16201#issuecomment-1771454607
