On Tue, 17 Oct 2023 21:23:38 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> Recent regression, see bug. The fix is to use the proper `jlong <-> ptr` > converters. > > Additional testing: > - [x] Build now passes on ARM32 > - [x] Two affected JMH benchmarks still run Thanks for fixing. I Suppose these benchmarks are not built in GitHub actions. test/micro/org/openjdk/bench/java/lang/foreign/libToCString.c line 24: > 22: */ > 23: > 24: #include <jlong_md.h> I think you just want `jlong.h` here? AFAIK the `jlong_md.h` is the platform specific implementation file, whereas `jlong.h` is the 'interface'. (though, `jlong.h` just includes `jlong_md.h` so it probably doesn't really matter in practice) ------------- Marked as reviewed by jvernee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16228#pullrequestreview-1683935665 PR Review Comment: https://git.openjdk.org/jdk/pull/16228#discussion_r1363135178
