On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
> Please review this changeset for adding support for `--module` (-m) option > for CDS. > Changes in the `ModuleBootstrap.java` are needed so that the > `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if > the main module is specified. The module name will be stored in the ro region > of the CDS archive. During runtime, the archived module name will be compared > with the runtime module name. If comparison fails, the archived full module > graph won't be used. > > Note: this RFE is a subtask of > [JDK-8266329](https://bugs.openjdk.org/browse/JDK-8266329). More subtask(s) > will be created to support other options such as `--add-modules`. > > Passed tiers 1 - 4 testing. src/hotspot/share/classfile/modules.cpp line 567: > 565: #endif > 566: > 567: void Modules::dump_module_name() { This function should be `dump_main_module_name()` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16016#discussion_r1362928947
