On Mon, 16 Oct 2023 23:37:51 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY. Although some of the short names in the COMPAT provider are
>> somewhat questionable (less common ones are simply made up from the long
>> names by taking the initials), it would not be desirable for them to fall
>> back to the GMT format.
>> To mitigate the situation, CLDR can use the abbreviated names from the TZ
>> database, which contains legacy (major) short names as FORMAT. The CLDR
>> provider can use them instead of the GMT offset style. This enhancement is a
>> precursor to the future removal of the COMPAT provider.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use ZoneOffset to parse offset
Looks fine.
(I can't help thinking that some of this pre-processing would be easier to
maintain with a bit more formal parsing and creating of records for the data in
these files; but that's for another time.)
make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1294:
> 1292: .map(Path::toFile)
> 1293: .filter(File::isFile)
> 1294: .forEach(f -> {
I'd keep the Path going through the stream to avoid converting and then back
again.
Suggestion:
.filter(p -> p.toFile().isFile())
.forEach(p -> {
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16206#pullrequestreview-1681188045
PR Review Comment: https://git.openjdk.org/jdk/pull/16206#discussion_r1361419853
