On Wed, 11 Oct 2023 20:58:23 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> The goal of this PR is to address the follow-up comments to the SIMD >> accelerated sort PR (#14227) which implemented AVX512 intrinsics for >> Arrays.sort() methods. >> The proposed changes are: >> >> 1) Restriction of the AVX512 sort acceleration to only Intel CPUs. A >> performance regression (due to micro-architectural differences) was reported >> for AMD Zen4 CPUs in the comments section of PR. >> 2) Addressing the build failure due to a bug in GCC 12 (which was fixed in >> version 12.3.1). The details of the bug are at: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105593 >> 3) Minor changes in Javadoc strings > > Srinivas Vamsi Parasa has updated the pull request incrementally with one > additional commit since the last revision: > > Revert @ForceInline annotations for small array sort methods FTR I'm perfectly fine with handling it separately. > It is not easy to do. You need to make sure that you not enable intrinsic by > -XX:ControlIntrinsic= There's `VM_Version::is_intrinsic_supported()` introduced specifically for such type of platform-specific checks. `vmIntrinsics::is_intrinsic_available()` takes into account both `ControlIntrinsic`/`DisableIntrinsic` and `VM_Version::is_intrinsic_supported()`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16124#issuecomment-1758808390
