On Mon, 9 Oct 2023 14:42:33 GMT, Mahendra Chhipa <mchh...@openjdk.org> wrote:
>> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - Implemented the review comments. > 1. Now test uses Junit5. > 2. Created the seperate Utility class to generate the JDK version specific > java src file. > - Merge branch 'master' into JDK-8077371 > - Implemented review comments. > - Implemented the review comments. > - Move the pseudo code generation part from setup() to seperate methods. > - 1. Added JDK version in Data files. > 2. Updated copyright year. > - Implemented the review comments. > - Implemented the review comment. > - closed file handlers. > - JDK-8077371: Binary files in JAXP test should be removed Thanks for the update. I'm not sure it's necessary to repeat tests with Base64 input. I think Daniel's comment was that the data can be optionally base64-encoded into a string, not that the tests needed to be duplicated. The generatePseudoCodeFor... methods in the Util class can be consolidated too. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13537#issuecomment-1758394086
