On Wed, 11 Oct 2023 10:57:24 GMT, Joachim Kern <jk...@openjdk.org> wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX >> in TreeTest.test5. >> The reason is: Previously the implementation based on the /proc file system >> lead to double pids in the child list; at least intermittent. Using the API >> getprocs64() instead I was able to eliminate those double pids (and increase >> the performance by a factor of 4). Otherwise we would have to add an >> algorithm to filter out the doubles after creating the raw list. > > Joachim Kern has updated the pull request incrementally with one additional > commit since the last revision: > > cosmetic changes 2 src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c line 1: > 1: /* Maybe better just assign the starttime when it is needed `stimes[count] = ((jlong) ProcessBuffer[i].pi_start) *1000;` and avoid 2 lines of variable declaration and assignment ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16051#discussion_r1354778759
