On Tue, 10 Oct 2023 20:04:48 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> In #14227, you inadvertently added an extra space at line 230 in >> make/modules/java.base/Lib.gmk >> (https://github.com/openjdk/jdk/pull/14227/files#diff-c2e113e4b2661697750fd5e6dcc0908fa98563ccfb3801c8b0e3a70174041b81). >> >> Can you please revert it here? > >> In #14227, you inadvertently added an extra space at line 230 in >> make/modules/java.base/Lib.gmk > > Hi Magnus (@magicus), please see the extra space fixed in the latest commit. > > Thanks, > Vamsi Hi @vamsi-parasa , Methods `partitionDualPivot` and `partitionSinglePivot` are annotated by @ForceInline, but `mixedInsertionSort` and `insertionSort` are not. These all 4 methods are passed as parameter to methods `private static <A> int[] partition(Class<?> elemType, A array, ...` and `private static <A> void sort(Class<?> elemType, A array, ...`. Is ok that `partitionDualPivot`, `partitionSinglePivot` and `mixedInsertionSort`, `insertionSort` are annotated differently? Should we add @ForceInline to `mixedInsertionSort`, `insertionSort` or remove @ForceInline from `partitionDualPivot` and `partitionSinglePivot`? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16124#issuecomment-1756156620
