On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad <redes...@openjdk.org> wrote:
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
> URLEncodeDecode.testEncodeLatin1 75 15 0,934 ± 0,017 0,811 ± 0,014
> ms/op 1,15x (p = 0,000*)
> URLEncodeDecode.testEncodeLatin1 100 15 0,433 ± 0,060 0,389 ± 0,007
> ms/op 1,11x (p = 0,008*)
> * = significant
> ```
Looks good
test/jdk/java/util/BitSet/ImmutableBitSet.java line 65:
> 63: @Test
> 64: void basic() {
> 65: IntStream.of(0, 16, 143, 4711).forEach(k -> basic(k));
A test on either side of the boundary (128) in the implementation might be
useful.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16094#pullrequestreview-1667771776
PR Review Comment: https://git.openjdk.org/jdk/pull/16094#discussion_r1352558216
