On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey <coff...@openjdk.org> wrote:

> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source 
> objects aren't created for the same zip file.

src/java.base/share/classes/java/util/zip/ZipFile.java line 1418:

> 1416: 
> 1417:             @SuppressWarnings("removal")
> 1418:             private File getCanonicalFile(File file) {

Suggestion:

            private static File getCanonicalFile(File file) {

To avoid this-escape.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16115#discussion_r1352104428

Reply via email to