On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the >> details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Avoid localized integers in radix-out-of-range exception messages. Changes look reasonable. The inline logic (such as writing to `inRange` on each loop iteration) makes the logic a bit harder to follow, but I think the improved consistency across implementations trumps this concern. I noticed that `parse*(CharSequence..)` and `parseUnsigned` aren't covered by current microbenchmark. That ought to be fixed. ------------- Marked as reviewed by redestad (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16050#pullrequestreview-1660120147
