On Thu, 5 Oct 2023 08:20:58 GMT, Aggelos Biboudis <abimpou...@openjdk.org> wrote:
>> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelos Biboudis has updated the pull request incrementally with one > additional commit since the last revision: > > Declutter Lower.visitTypeTest src/java.base/share/classes/java/lang/runtime/ExactnessMethods.java line 35: > 33: * @since 22 > 34: */ > 35: final public class ExactnessMethods { I think it should be `public final` (order of modifier) src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 558: > 556: } > 557: > 558: record TypePairs(Class<?> from, Class<?> to) { Nice! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1347148799 PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1347149579
