On Wed, 20 Sep 2023 23:20:43 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXXXXXX.java will be renamed after review.
test/jdk/java/util/Calendar/Bug4766302.java line 32:
> 30: import java.util.GregorianCalendar;
> 31:
> 32: @SuppressWarnings("serial")
Is removing this OK?
test/jdk/java/util/Calendar/bug4028518.java line 41:
> 39: public class bug4028518 {
> 40:
> 41: // Ensure modifying cloned gregCalendar does not modify the original
Seems that the comment is saying the other way around
test/jdk/java/util/Calendar/bug4243802.java line 48:
> 46: void setUp() {
> 47: Locale.setDefault(Locale.US);
> 48: TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"));
If the test is not going to restore the original defaults with `tearDown()`,
I'd expect `othervm` explicitly on `@run` directive. (applies to other
locations)
test/jdk/java/util/Calendar/bug4316678.java line 58:
> 56: @Test
> 57: public void serializationTest() throws IOException,
> ClassNotFoundException {
> 58: TimeZone.setDefault(TimeZone.getTimeZone("PST"));
Not needed?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15853#discussion_r1333653061
PR Review Comment: https://git.openjdk.org/jdk/pull/15853#discussion_r1333655945
PR Review Comment: https://git.openjdk.org/jdk/pull/15853#discussion_r1333663335
PR Review Comment: https://git.openjdk.org/jdk/pull/15853#discussion_r1333665846
