On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflects review comments
test/jdk/java/util/Properties/StoreReproducibilityTest.java line 137:
> 135: final Path tmpFile = Files.createTempFile("8231640",
> ".props");
> 136: storedFiles.add(tmpFile);
> 137: final ProcessBuilder processBuilder =
> ProcessTools.createJavaProcessBuilder(
ProcessTools.createJavaProcessBuilder came up in another PR because it doesn't
prepend the VM and java opts. As all usages of PB are being updated in this
test then it makes me wonder if it should be changed to use createTestJvm while
you're there.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15829#discussion_r1332585761
