On Mon, 18 Sep 2023 20:08:31 GMT, iaroslavski <d...@openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove the unnecessary exception in single pivot partitioning fallback >> method > > ... more suggestions to have better code: > > 3. Rename introduced method arraySort() -> sort(), shorter and clear > 4. The same for arrayPartition() -> partition(), shorter and clear > 5. As I suggested before, please, remove line ``int[] pivotIndices;`` from > the beginning at all and use the following: > int[] pivotIndices = partition(....) in both usages > > Vansi, please, improve the code Hello Vladimir (@iaroslavski ) Thank you for the suggestions! Please see all the changes you suggested below implemented in the latest commit pushed. > 1. I found your changes "the array" -> "an array" in DPQS class > 3. Rename introduced method arraySort() -> sort(), shorter and clear > 4. The same for arrayPartition() -> partition(), shorter and clear > 5. As I suggested before, please, remove line `int[] pivotIndices;` from the > beginning at all and use the following: > int[] pivotIndices = partition(....) in both usages Thanks, Vamsi ------------- PR Comment: https://git.openjdk.org/jdk/pull/14227#issuecomment-1724730003
