On Wed, 13 Sep 2023 11:26:30 GMT, Sean Coffey <coff...@openjdk.org> wrote:

> Some log messages from the test may be dropped if the bootstraplogger is in 
> use at time of log call. (bootstap logger logs at INFO level, the security 
> event logger logs at DEBUG level)
> 
> Modify the test to use a patched EventHelper class to let it log at INFO 
> level also, ensuring the bootstrap logger handles such logs.
> 
> I'll log a follow on enhancement where the default logging level for 
> bootstrap logger can be modified (perhaps via the existing 
> `jdk.system.logger.level` system property)

Looks fine to me as a shorter term solution until the enhancement is done. An 
alternative enhancement could be to have another system property to configure 
at which level the EventHelper should log.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15711#pullrequestreview-1624746847

Reply via email to