On Thu, 7 Sep 2023 14:10:20 GMT, Soumadipta Roy <d...@openjdk.org> wrote:
>> This test is running in tier1, and takes about 400 seconds to complete. >> Thus, it drags the execution time of tier1 on large machines. The commit >> includes changing the sequential run of test cases in >> java/util/concurrent/tck/JSR166TestCase.java to the best possible >> combination of parallelization to reduce the total runtime of the overall >> test and causing least possible change to user and system times. The below >> comparison shows existing and newer combinations of parallelizations: >> >> * before : **200.64s user 20.94s system 204% cpu >> 1:48.47 total** >> * fully parallel : **308.84s user 23.75s system 479% cpu >> 1:09.42 total** >> * default-details-tck : **244.69s user 22.03s system 314% cpu 1:24.94 >> total** >> * default-fjp_details-tck : **260.12s user 24.47s system 404% cpu 1:10.31 >> total** >> >> Based on the comparison above, the fourth combination has a result very >> close to full parallelization and at the same time having the least >> deviation of system and user times among the newer combinations. Hence the >> commit includes the changes corresponding to the fourth combination. > > Soumadipta Roy has updated the pull request incrementally with one additional > commit since the last revision: > > Remove extra new line test/jdk/java/util/concurrent/tck/JSR166TestCase.java line 39: > 37: /* > 38: * @test id=default > 39: * @summary JSR-166 tck tests, in a number of variations. The @summary is stale - it describes the state when there was only one @test test/jdk/java/util/concurrent/tck/JSR166TestCase.java line 45: > 43: * @modules java.management > 44: * @run junit/othervm/timeout=1000 JSR166TestCase > 45: * @run junit/othervm/timeout=1000 -Djava.security.manager=allow > JSR166TestCase security manager testing is relatively less important. I would move this to a lower tier, while moving a test with -Djsr166.testImplementationDetails=true into tier1 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15619#discussion_r1318817536 PR Review Comment: https://git.openjdk.org/jdk/pull/15619#discussion_r1318820512
