On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung <mch...@openjdk.org> wrote:
> This reimplements
> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
> handles.
>
> This API currently generates the bytecode which fails the verification
> because `new C; invokespecial A()` where the given class `C` and invoke a
> no-arg constructor of `C`'s first non-`Serializable` superclass `A` is not a
> valid operation per the VM specification. VM special cases the classes
> generated for reflection to skip verification for the constructors generated
> for serialization and externalization. This change will allow such VM hack
> to be removed.
>
> A `jdk.reflect.useOldSerializableConstructor` system property can be set to
> use the old implementation in case if customers run into any compatibility
> issue. I expect this change has very low compatibility risk. This system
> property is undocumented and will be removed in a future release.
src/java.base/share/classes/jdk/internal/reflect/DirectMethodHandleAccessor.java
line 198:
> 196: if (!declaringClass.isAssignableFrom(o.getClass())) {
> 197: throw new IllegalArgumentException("object of type " +
> o.getClass().getName()
> 198: + " is not an instance of " +
> declaringClass.getName());
Suggestion:
+ " is not an instance of " + declaringClass.getName());
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15600#discussion_r1318295076
